Skip to content

Constants under ESP32 instead of GPIO module #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

vickash
Copy link
Contributor

@vickash vickash commented Mar 11, 2023

Since all of the names defined in the esp-idf already have component names prefixed, like GPIO_*, LEDC_* etc., they read better if all are defined at the top level of the ESP32 module. This also makes them consistent with the esp-idf documentation.

Example: ESP32::GPIO_NUM2 instead of ESP32::GPIO::GPIO_NUM2, when used from outside the scope of the GPIO module.

To fix scripts that top level include GPIO, add include ESP32::Constants.

@vickash vickash mentioned this pull request Jul 16, 2023
@yuuu yuuu merged commit 40c000b into mruby-esp32:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants