fix flaky test test_88_random_error #1171
Merged
+5
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
previously approved these changes
Jul 18, 2025
tests/issues/test_88_random_error.py
Outdated
| @@ -28,8 +28,7 @@ async def test_notification_validation_error(tmp_path: Path): | |||
|
|
|||
| server = Server(name="test") | |||
| request_count = 0 | |||
| slow_request_started = anyio.Event() | |||
| slow_request_complete = anyio.Event() | |||
| slow_request = anyio.Event() | |||
There was a problem hiding this comment.
nit: slow_request_lock to make it obvious what this is when reading the test further down
tests/issues/test_88_random_error.py
Outdated
| # Wait for slow request to complete in the background | ||
| with anyio.fail_after(1): # Timeout after 1 second | ||
| await slow_request_complete.wait() | ||
| # release the slow request not to have hagning process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is flaky.
operation, the test now uses anyio.Event() to have deterministic control over when the slow request completes
timing-related flakiness
controls the test flow