tests: mark trailing slash test as xfail #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pydantic's AnyUrl incorrectly adds trailing slashes to base URLs without paths. This behavior is being fixed in pydantic-core PR #1719 and will be available in Pydantic 2.12+. Instead of working around the issue, mark the test as expected to fail. This documents the known bug and will automatically alert when Pydantic fixes it (the test will XPASS with xfail_strict=true in pyproject.toml). Ref: pydantic/pydantic-core#1719
Kludex
approved these changes
Jul 14, 2025
felixweinberger
merged commit 4a6fbd3
into
fix-test-with-snapshot
17 of 18 checks passed
felixweinberger
added a commit
that referenced
this pull request
Jul 14, 2025
felixweinberger
added a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Address https://github.com/modelcontextprotocol/python-sdk/pull/945/files#r2192151570
How Has This Been Tested?
Ran full test suite.
Breaking Changes
None.
Types of changes
Checklist
Additional context