Skip to content

refactor: Replace Map<String, Object> with CallToolRequest in StructuredOutputCallToolHandler #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

tzolov
Copy link
Contributor

@tzolov tzolov commented Jul 17, 2025

Follow up to #357 to update tool call handler signature from Map<String, Object> to McpSchema.CallToolRequest for consistency with changes in #375.

  • Change BiFunction parameter from Map<String, Object> to McpSchema.CallToolRequest for better type safety
  • Update method signature to accept CallToolRequest instead of raw arguments map
  • Replace toolSpecification.call() with toolSpecification.callHandler()
  • Migrate to builder pattern for AsyncToolSpecification construction

…redOutputCallToolHandler

Follow up to #357 to update tool call handler signature from Map<String, Object>
to McpSchema.CallToolRequest for consistency with changes in #375.

- Change BiFunction parameter from Map<String, Object> to McpSchema.CallToolRequest for better type safety
- Update method signature to accept CallToolRequest instead of raw arguments map
- Replace toolSpecification.call() with toolSpecification.callHandler()
- Migrate to builder pattern for AsyncToolSpecification construction

Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
@tzolov tzolov added this to the 0.11.0 milestone Jul 17, 2025
Copy link
Contributor

@pantanurag555 pantanurag555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tzolov tzolov merged commit 53f7b77 into main Jul 18, 2025
1 check passed
@tzolov tzolov deleted the fix-structured-output-arguments branch July 18, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants