More efficient http #156 #157
Open
+145
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcapriolo
force-pushed
the
efficient-http
branch
2 times, most recently
from
8010c9b to
2976a72
Compare
9 tasks
edwardcapriolo
force-pushed
the
efficient-http
branch
from
2976a72 to
6a95378
Compare
edwardcapriolo
force-pushed
the
efficient-http
branch
from
7035219 to
7bd9ba2
Compare
|
Ping, each http request is being converted into a string before being processed :) nice simple improvement on queue now for 5 days :) |
|
Hey maintainers! Its been three months and no one has interacted with me. I did a PR to fix typos, someone else went and did a PR to fix the same typos! I did this PR and its a clear improvement, bytes->string-bytes. puts pressure on the JVM. What is the deal do you only accept PRS from your buddies? Ill make a new jithub account with a name close to someone elses and maybe that will make the PRs look better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do a quick search on GitHub issues first, the feature you are about to request might have already been requested.
Expected Behavior
Efficient correct HTTP
bad user data should return 400
Current Behavior
Bad data returns 5xx
Extrac copies of JSON messages are created in memory
Context
More memory pressure,
harder to debug