Skip to content

correctly updates known classes after teaching estimators #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

philipjhj
Copy link
Contributor

An attempt at solving issue #62.

Changing _set_classes to use other information in the learners (e.g. the labels of the given training data) than the classes known to the estimators broke tests, and was much more involved than moving the call to _set_classes into a local teach method to ensure the update happens after the training of the estimators.

Unsure whether the whole description of the teach function should be repeated.

@cosmic-cortex cosmic-cortex self-requested a review November 26, 2019 07:13
@cosmic-cortex cosmic-cortex merged commit 5dda5bf into modAL-python:dev Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants