-
Notifications
You must be signed in to change notification settings - Fork 778
added createOrgRepo for create organization repos #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @marcosomma. Thank you for your interest in this library. To consider your PR, we need you to write a test for the feature you want to add. |
|
||
// Create an Organization repo | ||
// ------- | ||
this.createOrgRepo = function (orgname, options, cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a new parameter, I think we can pass the organization name as part of the options.
hi @AurelioDeRosa thanks! This was just a fast change to make it work. I'll improve the code and also add the test asap I have time :) hopefully during the week end ;) |
Hi @AurelioDeRosa I just finish the tests and the modifications for this pull request. {
"message": "You need admin access to the organization before adding a reposito
ry to it.",
"error": 403
} As user I used the one present in the If you want take a look on it this is the branch where I implemented the tests and your suggestions :) and this is the commit resume. Please let me know what I have to do :) Thanks |
@AurelioDeRosa I fix the problem with the organization :) In local the Regards |
I also fix the naming conflict between my PR and this one to prevent conflict during the merging. |
No description provided.