Skip to content

added createOrgRepo for create organization repos #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

marcosomma
Copy link
Contributor

No description provided.

@AurelioDeRosa
Copy link
Member

Hi @marcosomma.

Thank you for your interest in this library. To consider your PR, we need you to write a test for the feature you want to add.


// Create an Organization repo
// -------
this.createOrgRepo = function (orgname, options, cb) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new parameter, I think we can pass the organization name as part of the options.

@marcosomma
Copy link
Contributor Author

hi @AurelioDeRosa thanks! This was just a fast change to make it work. I'll improve the code and also add the test asap I have time :) hopefully during the week end ;)

@marcosomma
Copy link
Contributor Author

Hi @AurelioDeRosa I just finish the tests and the modifications for this pull request.
But when I run the tests I receive this error from the git api:

{
     "message": "You need admin access to the organization before adding a reposito
ry to it.",
    "error": 403
}

As user I used the one present in the tests/user.json and as Organization openaddresses

If you want take a look on it this is the branch where I implemented the tests and your suggestions :) and this is the commit resume.
Could you set this user as admin for this organization? Is the only way to pass my tests.

Please let me know what I have to do :)

Thanks
@marcosomma

@marcosomma
Copy link
Contributor Author

@AurelioDeRosa I fix the problem with the organization :)
I also update the test/user.json to reuse the organization that I setup for this test user.

In local the npm test command run 72test and no one fail, but I think that the project have some problem in the .travis.yml file. I'm not able to pass the Travis build.

Regards
@marcosomma

@marcosomma
Copy link
Contributor Author

I also fix the naming conflict between my PR and this one to prevent conflict during the merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants