feat(v-b-modal): set role="button" if trigger element is not a button

tmorehouse · web-flow · commit aa45d3e15c4c · 2017-12-05T00:31:47.000-04:00
diff --git a/src/directives/modal/modal.js b/src/directives/modal/modal.js
@@ -1,14 +1,19 @@
 import target from '../../utils/target'
+import { setAttr } from '../../utils/dom'
 
 const listenTypes = {click: true}
 
 export default {
-// eslint-disable-next-line no-shadow-restricted-names
-  bind (undefined, binding, vnode) {
+  // eslint-disable-next-line no-shadow-restricted-names
+  bind (el, binding, vnode) {
     target(vnode, binding, listenTypes, ({targets, vnode}) => {
       targets.forEach(target => {
         vnode.context.$root.$emit('bv::show::modal', target, vnode.elm)
       })
     })
+    if (el.tagName !== 'BUTTON') {
+      // If element is not a button, we add `role="button"` for accessibility
+      setAttr(el, 'role', 'button')
+    }
   }
 }
