Don't set a default size for FT2Font #30319
Merged
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of handling non-scalable fonts and reducing font initialization, drop the default size from the `FT2Font` constructor. Non-scalable fonts are sometimes used for bitmap-backed emoji fonts. When we start supporting collection fonts (`.ttc`), then setting a size is a waste, as we will just need to read the count of fonts within. The renderer method `Renderer.draw_text` always sets a size immediately after creating the font object, so this doesn't affect anything in most cases. Only the direct `FT2Font` tests need changes.
github-project-automation
bot
moved this to Waiting for other PR
in Font and text overhaul
QuLogic
moved this from Waiting for other PR
to Ready for Review
in Font and text overhaul
anntzer
approved these changes
Jul 16, 2025
|
Would it make sense to add an optional |
|
Given that the target consumer of Font objects is the |
tacaswell
approved these changes
Jul 16, 2025
github-project-automation
bot
moved this from Ready for Review
to Done
in Font and text overhaul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In the interest of handling non-scalable fonts and reducing font initialization, drop the default size from the
FT2Fontconstructor. Non-scalable fonts are sometimes used for bitmap-backed emoji fonts. When we start supporting collection fonts (.ttc), then setting a size is a waste, as we will just need to read the count of fonts within.The renderer method
Renderer.draw_textalways sets a size immediately after creating the font object, so this doesn't affect anything in most cases. Only the directFT2Fonttests need changes.I'm only unsure whether we wish to somehow warn/deprecate when this the size isn't set explicitly.
PR checklist