Skip to content

Backport PR #30237: Add explicit **options: Any for add_subplot m… #30292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v3.10.x
Choose a base branch
from
+10 −5
Open

Backport PR #30237: Add explicit **options: Any for add_subplot m… #30292

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6da96da
Backport PR #30237: Add explicit `**options: Any` for `add_subplot` m…
jkseppan Jul 4, 2025
534dc2b
Axes3D
GameRoMan Jul 11, 2025
a863384
axes3d
GameRoMan Jul 11, 2025
4244fb2
#29341
GameRoMan Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/matplotlib/figure.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ from matplotlib.lines import Line2D
from matplotlib.patches import Rectangle, Patch
from matplotlib.text import Text
from matplotlib.transforms import Affine2D, Bbox, BboxBase, Transform
from mpl_toolkits.mplot3d import Axes3D

from .typing import ColorType, HashableList

_T = TypeVar("_T")
Expand Down Expand Up @@ -87,17 +89,20 @@ class FigureBase(Artist):

# TODO: docstring indicates SubplotSpec a valid arg, but none of the listed signatures appear to be that
@overload
def add_subplot(self, *args: Any, projection: Literal["3d"], **kwargs: Any) -> Axes3D: ...
@overload
def add_subplot(
self, nrows: int, ncols: int, index: int | tuple[int, int], **kwargs
self, nrows: int, ncols: int, index: int | tuple[int, int], **kwargs: Any
) -> Axes: ...
@overload
def add_subplot(self, pos: int, **kwargs) -> Axes: ...
def add_subplot(self, pos: int, **kwargs: Any) -> Axes: ...
@overload
def add_subplot(self, ax: Axes, **kwargs) -> Axes: ...
def add_subplot(self, ax: Axes, **kwargs: Any) -> Axes: ...
@overload
def add_subplot(self, ax: SubplotSpec, **kwargs) -> Axes: ...
def add_subplot(self, ax: SubplotSpec, **kwargs: Any) -> Axes: ...
@overload
def add_subplot(self, **kwargs) -> Axes: ...
def add_subplot(self, **kwargs: Any) -> Axes: ...

@overload
def subplots(
self,
Expand Down
Loading