-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[ENH] Add data parameter in Axes3D.plot #30270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vagnermcj
wants to merge
19
commits into
matplotlib:main
Choose a base branch
from
vagnermcj:new_feature_issue_30238
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−22
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b468641
Add data parameters to plot function in axes3d + add test for data pl…
livlutz 58a7d21
Test Handling
vagnermcj b2f9714
Refactor test_plot_data to use explicit lists for coordinates
livlutz ca0629b
Merge branch 'new_feature_issue_30238' of https://github.com/vagnermc…
livlutz ef4216c
Refactor test_plot_data to use explicit lists for coordinates
livlutz ece6b0e
Merge branch 'matplotlib:main' into new_feature_issue_30238
livlutz 809e804
Test adjustments
vagnermcj c451c29
new test checking
vagnermcj edb05b7
CI Fix
vagnermcj 93469e7
CI docstring fix
vagnermcj e75e13b
implemented test plot data
BrunoWolf03 1d8d69d
Merge branch 'matplotlib:main' into new_feature_issue_30238
livlutz c0b2bf7
Adding API change notes to plot method in Axes3D class
livlutz 688e153
Using the preprocess data decorator fot the axes3d method
livlutz 34cd222
Refactor plot method in Axes3D class to simplify parameter handling
livlutz 0598149
Merge branch 'matplotlib:main' into new_feature_issue_30238
livlutz 83157fa
Merge branch 'matplotlib:main' into new_feature_issue_30238
livlutz 98b9c66
Refactor plot doc + test with implicit zs=0
livlutz 0c04c8a
Update Axes3D.plot docstring to clarify parameter types and signature…
livlutz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, you've significantly mixed up the docstring:
..versionchanged:: 3.10
from axlim_clip to the topParameters
section**kwargs
Please take more care when submitting changes. These are all aspects that you should have been able to detect yourself and not something we should be spending valuable reviewer time on.