Pass on prop to parent in AnchoredDrawingArea #26059
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Jun 19, 2023
|
Conceptually this is correct, though I wonder whether we should deprecate AnchoredDrawingArea/AnchoredAuxTransformBox for reasons similar to #25781 (the use case is more real, but there isn't really any benefit in squashing together the args of the two constructors -- you more or less need to understand how the two component classes (AnchoredOffsetbox & DrawingArea/AuxTransformBox) work to make use of the composite class. |
|
I cannot say that I fully checked the surrounding code, just happened to notice that But checking a bit more carefully I can agree that the benefit of having these wrapper classes is limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Not sure if this is the right way to do it, but otherwise prop is unused... (It has been like this since the code first got in...)
PR checklist