Skip to content

Changes in the image for test_load_from_url #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Changes in the image for test_load_from_url #17776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/matplotlib/tests/test_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ def test_minimized_rasterized():


def test_load_from_url():
path = Path(__file__).parent / "baseline_images/test_image/imshow.png"
path = Path(__file__).parent / "baseline_images/pngsuite/basn3p04.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we think this image will be permanent either, and it seems a very obscure image to choose. Isn't there something in mpl_data/images that would be more appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image will remain as it is also used in

matplotlib/lib/matplotlib/tests/test_image.py

Line 151 in 50a535c

png_path = Path(__file__).parent / "baseline_images/pngsuite/basn3p04.png"
.
Secondly, the basn3p04.png image is not used in image_comparison tests. So, we don't need to shift it into the mpl_baseline_images package in #17557

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But shouldn’t that be moved as well? It’s going to be pretty confusing to have baseline_images and another package of baseline_images.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary reason the basn*.png files exist is as input for the test in test_png so is not in the category of images that will be removed by the GSOC code landing. On the other hand, the file that this used to point is a baseline image that will be removed.

url = ('file:'
+ ('///' if sys.platform == 'win32' else '')
+ path.resolve().as_posix())
Expand Down