FIX: Event loop timers should only run for the specified time

greglucas · greglucas · commit f6e282b9eb44 · 2024-10-25T07:12:11.000-06:00
The implementation of start_event_loop would previously just count
the number of sleeps that occurred. But this could lead to longer
event loop times if flush_events() added time into the loop. We
want the condition to be dependent on the end-time so we don't
run our loop longer than necessary.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -2321,12 +2321,10 @@ def start_event_loop(self, timeout=0):
         if timeout <= 0:
             timeout = np.inf
         timestep = 0.01
-        counter = 0
-        self._looping = True
-        while self._looping and counter * timestep < timeout:
+        t_end = time.time() + timeout
+        while time.time() < t_end:
             self.flush_events()
             time.sleep(timestep)
-            counter += 1
 
     def stop_event_loop(self):
         """
