CI: Unify required dependencies installation

Kojoley · Kojoley · commit df5b18009bec · 2020-01-06T20:13:27.000+03:00
- Do not update default Conda packages (saves 5 minutes on 3.6 job)
- Do not install Freetype2 from Conda (we do not use it anyway)
- Install dependencies via pip, the same way as it's done on Travis.
  However, `travis36minver.txt` cannot be used, because of some bugs
  in the pinned versions (something with pandas/pytz/dateutils)
- Test sphinext on Travis
- Test PyQt5 and PySide2 backend on Appveyor
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -26,6 +26,7 @@ environment:
     - PYTHON_VERSION: "3.6"
       CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
       TEST_ALL: "no"
+      EXTRAREQS: "-r requirements/testing/travis36.txt"
     - PYTHON_VERSION: "3.7"
       CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64"
       TEST_ALL: "no"
@@ -49,22 +50,34 @@ install:
   - set PATH=%CONDA_INSTALL_LOCN%;%CONDA_INSTALL_LOCN%\scripts;%PATH%;
   - set PYTHONUNBUFFERED=1
   - conda config --set always_yes true
-  - conda update --all
   - conda config --set show_channel_urls yes
   - conda config --prepend channels conda-forge
-  # this is now the downloaded conda...
-  - activate
-  - conda info -a
 
   # For building, use a new environment which only includes the requirements for mpl
   # if conda-forge gets a new pyqt, it might be nice to install it as well to have more backends
   # https://github.com/conda-forge/conda-forge.github.io/issues/157#issuecomment-223536381
   - conda create -q -n test-environment python=%PYTHON_VERSION%
-    freetype=2.6 tk=8.5
-    pip setuptools numpy sphinx tornado
+    pip setuptools wheel libpng zlib tk
   - activate test-environment
   - echo %PYTHON_VERSION% %TARGET_ARCH%
-  - pip install -r requirements/testing/travis_all.txt -r requirements/testing/travis36.txt
+  # Install dependencies from PyPI.
+  - python -mpip install --upgrade -r requirements/testing/travis_all.txt %EXTRAREQS% %PINNEDVERS%
+  # Install optional dependencies from PyPI.
+  # Sphinx is needed to run sphinxext tests
+  - python -mpip install --upgrade sphinx
+  # GUI toolkits are pip-installable only for some versions of Python so
+  # don't fail if we can't install them.  Make it easier to check whether the
+  # install was successful by trying to import the toolkit (sometimes, the
+  # install appears to be successful but shared libraries cannot be loaded at
+  # runtime, so an actual import is a better check).
+  - python -mpip install --upgrade pyqt5 &&
+      python -c "import PyQt5.QtCore" &&
+      echo PyQt5 is available ||
+      echo PyQt5 is not available
+  - python -mpip install --upgrade pyside2 &&
+      python -c "import PySide2.QtCore" &&
+      echo PySide2 is available ||
+      echo PySide2 is not available
 
   # Apply patch to `subprocess` on Python versions > 2 and < 3.6.3
   # https://github.com/matplotlib/matplotlib/issues/9176
@@ -84,7 +97,7 @@ test_script:
   - '"%DUMPBIN%" /DEPENDENTS lib\matplotlib\ft2font*.pyd | findstr freetype.*.dll && exit /b 1 || exit /b 0'
 
   # this are optional dependencies so that we don't skip so many tests...
-  - if x%TEST_ALL% == xyes conda install -q ffmpeg inkscape miktex pillow
+  - if x%TEST_ALL% == xyes conda install -q ffmpeg inkscape miktex
   # missing packages on conda-forge for avconv imagemagick
   # This install sometimes failed randomly :-(
   #- choco install imagemagick
diff --git a/.travis.yml b/.travis.yml
@@ -133,6 +133,8 @@ install:
     python -mpip install --upgrade $PRE -r requirements/testing/travis_all.txt $EXTRAREQS $PINNEDVERS
   - |
     # Install optional dependencies from PyPI.
+    # Sphinx is needed to run sphinxext tests
+    python -mpip install --upgrade sphinx
     # GUI toolkits are pip-installable only for some versions of Python so
     # don't fail if we can't install them.  Make it easier to check whether the
     # install was successful by trying to import the toolkit (sometimes, the
diff --git a/lib/matplotlib/tests/test_backend_qt.py b/lib/matplotlib/tests/test_backend_qt.py
@@ -1,4 +1,5 @@
 import copy
+import os
 import sys
 from unittest import mock
 
@@ -245,6 +246,9 @@ def test_dpi_ratio_change():
         # The DPI and the renderer width/height change
         assert fig.dpi == 240
         assert qt_canvas.renderer.width == 1200
+        if os.environ.get('APPVEYOR', False):
+            pytest.xfail("Temporary disabled. See https://github.com/"
+                         "matplotlib/matplotlib/issues/16123")
         assert qt_canvas.renderer.height == 480
 
         # The actual widget size and figure physical size don't change
