Skip to content

Commit af4469e

Browse files
committed
Improve docs on automated tests
1 parent 065769b commit af4469e

File tree

1 file changed

+30
-9
lines changed

1 file changed

+30
-9
lines changed

doc/devel/coding_guide.rst

Lines changed: 30 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,24 +161,45 @@ Merging
161161
A core dev should only champion one PR at a time and we should try to keep
162162
the flow of championed PRs reasonable.
163163

164+
* Do not self merge, except for 'small' patches to un-break the CI or
165+
when another reviewer explicitly allows it (ex, "Approve modulo CI
166+
passing, may self merge when green").
167+
164168
.. _pr-automated-tests:
165169

166170
Automated tests
167171
---------------
168172

169-
* Make sure the Travis, Appveyor, CircleCI, and codecov tests are passing
170-
before merging.
173+
Whenever a pull request is created or updated, various automated test tools
174+
will run on all supported platforms and versions of Python.
175+
176+
* Make sure the Travis, Appveyor, CircleCI, and Azure pipelines are passing
177+
before merging (All checks are listed at the bottom of the GitHub page of
178+
your pull request). Here are some tips for finding the cause of the test
179+
failure:
180+
181+
- If *Travis flake8* fails, you have a code style issue, which will be listed
182+
near the bottom of the *Travis flake8* log.
183+
- If any other Travis run fails, search the log for ``FAILURES``. The
184+
subsequent section will contain information on the failed tests.
185+
- If CircleCI fails, likely you have some reStructuredText style issue in
186+
the docs. Search the CircleCI log for ``WARNING``.
187+
- If Azure pipelines fail with an image comparison error, you can find the
188+
images as *artifacts* of the Azure job:
171189

172-
- Whenever a pull request is created or updated, Travis and Appveyor
173-
automatically runs the test suite on all versions of Python
174-
supported by Matplotlib. The tox_ support in Matplotlib may be
175-
useful for testing locally.
190+
- Click *Details* on the check on the GitHub PR page.
191+
- Click *View more details on Azure Pipelines* to go to Azure.
192+
- On the overview page *artifacts* are listed in the section *Related*.
193+
194+
195+
* Codecov and LGTM are currently for information only. Their failure is not
196+
necessarily a blocker.
197+
198+
* tox_ is not used in the automated testing. It is supported for testing
199+
locally.
176200

177201
.. _tox: https://tox.readthedocs.io/
178202

179-
* Do not self merge, except for 'small' patches to un-break the CI or
180-
when another reviewer explicitly allows it (ex, "Approve modulo CI
181-
passing, may self merge when green").
182203

183204
.. _pr-squashing:
184205

0 commit comments

Comments
 (0)