Refactor share code.

lkjell · lkjell · commit 9b82dc25b0b9 · 2018-03-09T18:19:42.000+01:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -4335,49 +4335,37 @@ def unshare_axes(self, axes=None):
         self.unshare_x_axes(axes)
         self.unshare_y_axes(axes)
 
-    def _share_axes(self, axes, shared_axes, symmetric=True, transitive=True):
-        if symmetric:
-            sharedA = getattr(self, "_shared_{}_axes".format(shared_axes))
-            sharedB = getattr(axes, "_shared_{}_axes".format(shared_axes))
-
-            # Adding to main share list
-            sharedA.add(axes)
-            sharedB.add(self)
+    @staticmethod
+    def _share_axes_symmetric(A, B, shared_axes):
+        """Share A -> B, and B -> A"""
+        _AxesBase._share_axes_asymmetric(A, B, shared_axes)
+        _AxesBase._share_axes_asymmetric(B, A, shared_axes)
 
-            # Adding to all share list
-            sharedA = getattr(self, "_shared_{}_inv_axes".format(shared_axes))
-            sharedB = getattr(axes, "_shared_{}_inv_axes".format(shared_axes))
+    @staticmethod
+    def _share_axes_asymmetric(A, B, shared_axes):
+        """Share A -> B"""
+        getattr(A, "_shared_{}_axes".format(shared_axes)).add(B)
+        getattr(B, "_shared_{}_inv_axes".format(shared_axes)).add(A)
 
-            sharedA.add(axes)
-            sharedB.add(self)
+    def _share_axes(self, axes, shared_axes, symmetric=True, transitive=True):
+        if symmetric:
+            self._share_axes_symmetric(self, axes, shared_axes)
         else:
-            sharedA = getattr(self, "_shared_{}_axes".format(shared_axes))
-            sharedB = getattr(axes, "_shared_{}_inv_axes".format(shared_axes))
-
-            sharedA.add(axes)
-            sharedB.add(self)
+            self._share_axes_asymmetric(self, axes, shared_axes)
 
         if transitive:
             sharedA = getattr(self, "_shared_{}_axes".format(shared_axes))
             sharedB = getattr(axes, "_shared_{}_axes".format(shared_axes))
 
             sharedDiffBA = sharedB - sharedA
             sharedDiffAB = sharedA - sharedB
-            # A share all that is in B.
-            sharedA |= sharedB
 
             for ax in sharedDiffBA:
-                shared = getattr(ax, "_shared_{}_inv_axes".format(shared_axes))
-                shared.add(self)
+                self._share_axes_asymmetric(self, ax, shared_axes)
 
-            # B share all that is in A
             if symmetric:
-                sharedB |= sharedA
-
                 for ax in sharedDiffAB:
-                    shared = getattr(ax,
-                                     "_shared_{}_inv_axes".format(shared_axes))
-                    shared.add(axes)
+                    self._share_axes_asymmetric(axes, ax, shared_axes)
 
     def share_x_axes(self, axes, symmetric=True, transitive=True):
         """
