Fix zorder handling for OffsetBoxes and subclasses.

anntzer · anntzer · commit 53dce944c348 · 2021-03-27T12:45:58.000+01:00
`kwargs` need to be handled separately via `Artist.update`.  This
pattern is consistent with other artist subclasses (Line2D, _ImageBase,
Text, etc.).
diff --git a/lib/matplotlib/offsetbox.py b/lib/matplotlib/offsetbox.py
@@ -192,14 +192,12 @@ class OffsetBox(martist.Artist):
     Being an artist itself, all parameters are passed on to `.Artist`.
     """
     def __init__(self, *args, **kwargs):
-
-        super().__init__(*args, **kwargs)
-
+        super().__init__(*args)
+        self.update(kwargs)
         # Clipping has not been implemented in the OffesetBox family, so
         # disable the clip flag for consistency. It can always be turned back
         # on to zero effect.
         self.set_clip_on(False)
-
         self._children = []
         self._offset = (0, 0)
 
diff --git a/lib/matplotlib/tests/test_offsetbox.py b/lib/matplotlib/tests/test_offsetbox.py
@@ -12,8 +12,8 @@
 from matplotlib.backend_bases import MouseButton
 
 from matplotlib.offsetbox import (
-        AnchoredOffsetbox, AnnotationBbox, AnchoredText, DrawingArea,
-        OffsetImage, TextArea, _get_packed_offsets)
+    AnchoredOffsetbox, AnnotationBbox, AnchoredText, DrawingArea, OffsetBox,
+    OffsetImage, TextArea, _get_packed_offsets)
 
 
 @image_comparison(['offsetbox_clipping'], remove_text=True)
@@ -321,3 +321,7 @@ def test_annotationbbox_extents():
     fig.canvas.draw()
     fig.tight_layout()
     fig.canvas.draw()
+
+
+def test_zorder():
+    assert OffsetBox(zorder=42).zorder == 42
