Add support for High DPI displays to wxAgg backend

jmoraleda · jmoraleda · commit 1b508140ba34 · 2023-09-20T12:09:11.000-04:00
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -14,9 +14,6 @@
 import sys
 import weakref
 
-import numpy as np
-import PIL.Image
-
 import matplotlib as mpl
 from matplotlib.backend_bases import (
     _Backend, FigureCanvasBase, FigureManagerBase,
@@ -30,6 +27,7 @@
 from matplotlib.transforms import Affine2D
 
 import wx
+import wx.svg
 
 _log = logging.getLogger(__name__)
 
@@ -473,10 +471,8 @@ def __init__(self, parent, id, figure=None):
         FigureCanvasBase.__init__(self, figure)
         w, h = map(math.ceil, self.figure.bbox.size)
         # Set preferred window size hint - helps the sizer, if one is connected
-        wx.Panel.__init__(self, parent, id, size=wx.Size(w, h))
-        # Create the drawing bitmap
-        self.bitmap = wx.Bitmap(w, h)
-        _log.debug("%s - __init__() - bitmap w:%d h:%d", type(self), w, h)
+        wx.Panel.__init__(self, parent, id, size=parent.FromDIP(wx.Size(w, h)))
+        self.bitmap = None
         self._isDrawn = False
         self._rubberband_rect = None
         self._rubberband_pen_black = wx.Pen('BLACK', 1, wx.PENSTYLE_SHORT_DASH)
@@ -524,6 +520,12 @@ def Copy_to_Clipboard(self, event=None):
                 wx.TheClipboard.Flush()
                 wx.TheClipboard.Close()
 
+    def _update_device_pixel_ratio(self, *args, **kwargs):
+        # We need to be careful in cases with mixed resolution displays if
+        # device_pixel_ratio changes.
+        if self._set_device_pixel_ratio(self.GetDPIScaleFactor()):
+            self.draw()
+
     def draw_idle(self):
         # docstring inherited
         _log.debug("%s - draw_idle()", type(self))
@@ -631,7 +633,7 @@ def _on_size(self, event):
         In this application we attempt to resize to fit the window, so it
         is better to take the performance hit and redraw the whole window.
         """
-
+        self._update_device_pixel_ratio()
         _log.debug("%s - _on_size()", type(self))
         sz = self.GetParent().GetSizer()
         if sz:
@@ -655,9 +657,10 @@ def _on_size(self, event):
             return  # Empty figure
 
         # Create a new, correctly sized bitmap
-        self.bitmap = wx.Bitmap(self._width, self._height)
-
         dpival = self.figure.dpi
+        if not wx.Platform == '__WXMSW__':
+            scale = self.GetDPIScaleFactor()
+            dpival /= scale
         winch = self._width / dpival
         hinch = self._height / dpival
         self.figure.set_size_inches(winch, hinch, forward=False)
@@ -712,7 +715,11 @@ def _mpl_coords(self, pos=None):
         else:
             x, y = pos.X, pos.Y
         # flip y so y=0 is bottom of canvas
-        return x, self.figure.bbox.height - y
+        if not wx.Platform == '__WXMSW__':
+            scale = self.GetDPIScaleFactor()
+            return x*scale, self.figure.bbox.height - y*scale
+        else:
+            return x, self.figure.bbox.height - y
 
     def _on_key_down(self, event):
         """Capture key press."""
@@ -898,8 +905,8 @@ def __init__(self, num, fig, *, canvas_class):
         # On Windows, canvas sizing must occur after toolbar addition;
         # otherwise the toolbar further resizes the canvas.
         w, h = map(math.ceil, fig.bbox.size)
-        self.canvas.SetInitialSize(wx.Size(w, h))
-        self.canvas.SetMinSize((2, 2))
+        self.canvas.SetInitialSize(self.FromDIP(wx.Size(w, h)))
+        self.canvas.SetMinSize(self.FromDIP(wx.Size(2, 2)))
         self.canvas.SetFocus()
 
         self.Fit()
@@ -1017,9 +1024,6 @@ def _set_frame_icon(frame):
 class NavigationToolbar2Wx(NavigationToolbar2, wx.ToolBar):
     def __init__(self, canvas, coordinates=True, *, style=wx.TB_BOTTOM):
         wx.ToolBar.__init__(self, canvas.GetParent(), -1, style=style)
-
-        if 'wxMac' in wx.PlatformInfo:
-            self.SetToolBitmapSize((24, 24))
         self.wx_ids = {}
         for text, tooltip_text, image_file, callback in self.toolitems:
             if text is None:
@@ -1028,7 +1032,7 @@ def __init__(self, canvas, coordinates=True, *, style=wx.TB_BOTTOM):
             self.wx_ids[text] = (
                 self.AddTool(
                     -1,
-                    bitmap=self._icon(f"{image_file}.png"),
+                    bitmap=self._icon(f"{image_file}.svg"),
                     bmpDisabled=wx.NullBitmap,
                     label=text, shortHelp=tooltip_text,
                     kind=(wx.ITEM_CHECK if text in ["Pan", "Zoom"]
@@ -1054,9 +1058,7 @@ def _icon(name):
         *name*, including the extension and relative to Matplotlib's "images"
         data directory.
         """
-        pilimg = PIL.Image.open(cbook._get_data_path("images", name))
-        # ensure RGBA as wx BitMap expects RGBA format
-        image = np.array(pilimg.convert("RGBA"))
+        svg = cbook._get_data_path("images", name).read_bytes()
         try:
             dark = wx.SystemSettings.GetAppearance().IsDark()
         except AttributeError:  # wxpython < 4.1
@@ -1068,11 +1070,9 @@ def _icon(name):
             fg_lum = (.299 * fg.red + .587 * fg.green + .114 * fg.blue) / 255
             dark = fg_lum - bg_lum > .2
         if dark:
-            fg = wx.SystemSettings.GetColour(wx.SYS_COLOUR_WINDOWTEXT)
-            black_mask = (image[..., :3] == 0).all(axis=-1)
-            image[black_mask, :3] = (fg.Red(), fg.Green(), fg.Blue())
-        return wx.Bitmap.FromBufferRGBA(
-            image.shape[1], image.shape[0], image.tobytes())
+            svg = svg.replace(b'fill:black;', b'fill:white;')
+        toolbarIconSize = wx.ArtProvider().GetDIPSizeHint(wx.ART_TOOLBAR)
+        return wx.BitmapBundle.FromSVG(svg, toolbarIconSize)
 
     def _update_buttons_checked(self):
         if "Pan" in self.wx_ids:
diff --git a/lib/matplotlib/backends/backend_wxagg.py b/lib/matplotlib/backends/backend_wxagg.py
@@ -12,13 +12,13 @@ def draw(self, drawDC=None):
         Render the figure using agg.
         """
         FigureCanvasAgg.draw(self)
-        self.bitmap = _rgba_to_wx_bitmap(self.get_renderer().buffer_rgba())
+        self.bitmap = self._create_bitmap()
         self._isDrawn = True
         self.gui_repaint(drawDC=drawDC)
 
     def blit(self, bbox=None):
         # docstring inherited
-        bitmap = _rgba_to_wx_bitmap(self.get_renderer().buffer_rgba())
+        bitmap = self._create_bitmap()
         if bbox is None:
             self.bitmap = bitmap
         else:
@@ -31,11 +31,13 @@ def blit(self, bbox=None):
             srcDC.SelectObject(wx.NullBitmap)
         self.gui_repaint()
 
-
-def _rgba_to_wx_bitmap(rgba):
-    """Convert an RGBA buffer to a wx.Bitmap."""
-    h, w, _ = rgba.shape
-    return wx.Bitmap.FromBufferRGBA(w, h, rgba)
+    def _create_bitmap(self):
+        """Create a wx.Bitmap from the renderer RGBA buffer"""
+        rgba = self.get_renderer().buffer_rgba()
+        h, w, _ = rgba.shape
+        bitmap = wx.Bitmap.FromBufferRGBA(w, h, rgba)
+        bitmap.SetScaleFactor(self.GetDPIScaleFactor())
+        return bitmap
 
 
 @_BackendWx.export
