Correctly hide download buttons using CSS

timhoffm · timhoffm · commit 0c45a64116eb · 2023-04-15T11:24:37.000+02:00
`visibility:hidden; height: 0px` still keeps margins, creating a large
amount of whitespace. `display: none` is the correct way to remove an
HTML element completely.
diff --git a/doc/_static/mpl.css b/doc/_static/mpl.css
@@ -62,12 +62,11 @@ html[data-theme="dark"] .sphx-glr-thumbcontainer {
     padding: 0;
 }
 
-/* hide note linking to the download section at the bottom of galleries
- * as suggested in https://github.com/sphinx-gallery/sphinx-gallery/issues/760
+/* hide download buttons in example headers
+ * https://sphinx-gallery.github.io/stable/advanced.html#hide-the-download-buttons-in-the-example-headers
  */
 div.sphx-glr-download-link-note {
-    height: 0px;
-    visibility: hidden;
+    display: none;
 }
 
 /* re-style the download button */

Original file line number	Diff line number	Diff line change
`@@ -62,12 +62,11 @@ html[data-theme="dark"] .sphx-glr-thumbcontainer {`
`62`	`62`	`padding: 0;`
`63`	`63`	`}`
`64`	`64`
`65`		`-/* hide note linking to the download section at the bottom of galleries`
`66`		`- * as suggested in https://github.com/sphinx-gallery/sphinx-gallery/issues/760`
	`65`	`+/* hide download buttons in example headers`
	`66`	`+ * https://sphinx-gallery.github.io/stable/advanced.html#hide-the-download-buttons-in-the-example-headers`
`67`	`67`	`*/`
`68`	`68`	`div.sphx-glr-download-link-note {`
`69`		`- height: 0px;`
`70`		`- visibility: hidden;`
	`69`	`+ display: none;`
`71`	`70`	`}`
`72`	`71`
`73`	`72`	`/* re-style the download button */`