[Fix]: #1849 optimize api calls for advanced setting page

iamfaran · iamfaran · commit 52fe54855095 · 2025-07-21T17:29:16.000+05:00
diff --git a/client/packages/lowcoder/src/pages/setting/advanced/AdvancedSetting.tsx b/client/packages/lowcoder/src/pages/setting/advanced/AdvancedSetting.tsx
@@ -96,9 +96,18 @@ export function AdvancedSetting() {
   }, [currentUser.currentOrgId])
 
   useEffect(() => {
-    dispatch(fetchCommonSettings({ orgId: currentUser.currentOrgId }));
-    dispatch(fetchAllApplications({}));
-  }, [currentUser.currentOrgId, dispatch]);
+    // Only fetch common settings if not already loaded
+    if (Object.keys(commonSettings).length === 0) {
+      dispatch(fetchCommonSettings({ orgId: currentUser.currentOrgId }));
+    }
+  }, [currentUser.currentOrgId, dispatch, commonSettings]);
+
+  // Lazy load applications only when dropdown is opened
+  const handleDropdownOpen = () => {
+    if (appList.length === 0) {
+      dispatch(fetchAllApplications({}));
+    }
+  };
 
   useEffect(() => {
     setSettings(commonSettings);
@@ -176,6 +185,9 @@ export function AdvancedSetting() {
             onChange={(value: string) => {
               setSettings((v) => ({ ...v, defaultHomePage: value }));
             }}
+            onDropdownVisibleChange={(open) => {
+              if (open) handleDropdownOpen();
+            }}
             options={appListOptions}
             filterOption={(input, option) => (option?.label as string).includes(input)}
           />
