Skip to content

WIP: add S3Control native provider #9730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: add S3Control native provider #9730

wants to merge 3 commits into from

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 24, 2023 •
edited
Loading

Motivation

Currently fully implemented in Moto, it would be easier to have it native for better compatibility with the S3 v3 provider. It would also allow us to support Access Point in the v3 provider (Moto just added partial support, but it's not fully in parity with AWS).
This is a pretty small provider, we can aim for same features as Moto for now.

Implementation of S3 Access Point compatibility will come in a next PR.

Resources:

Changes

Operations to implement (currently implemented in Moto):

Of course, S3Control is also very weird with the rest-xml protocol, and it needs its own serializer for now. 🙄 and some specs patches as well.

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Nov 24, 2023
@bentsku bentsku added this to the 3.1 milestone Nov 24, 2023
@bentsku bentsku self-assigned this Nov 24, 2023
@coveralls
Copy link

coveralls commented Nov 24, 2023 •
edited
Loading

Coverage Status

coverage: 84.161% (+0.006%) from 84.155%
when pulling f6e2fa0 on add-s3-control
into f241251 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±  0         2 suites  ±0   1h 7m 49s ⏱️ -4s
2 381 tests +10  2 065 ✔️ +9  316 💤 +1  0 ❌ ±0 
2 382 runs  +10  2 065 ✔️ +9  317 💤 +1  0 ❌ ±0 

Results for commit f6e2fa0. ± Comparison against base commit f241251.

This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both. 
tests.aws.services.s3control.test_s3control ‑ test_lifecycle_public_access_block
tests.aws.services.s3control.test_s3control ‑ test_public_access_block_validations

tests.aws.services.s3control.test_s3control.TestLegacyS3Control ‑ test_lifecycle_public_access_block
tests.aws.services.s3control.test_s3control.TestLegacyS3Control ‑ test_public_access_block_validations
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_already_exists
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_bucket_not_exists
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_lifecycle
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_name_validation
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_pagination
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_public_access_block_configuration
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_regions
tests.aws.services.s3control.test_s3control.TestS3ControlAccessPoint ‑ test_access_point_vpc_config
…

♻️ This comment has been updated with latest results.

@bentsku bentsku modified the milestones: 3.1, Playground Nov 28, 2023
@github-actions GitHub Actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0      2 suites  ±0   3m 21s ⏱️ +6s
376 tests ±0  326 ✔️ ±0    50 💤 ±0  0 ❌ ±0 
752 runs  ±0  652 ✔️ ±0  100 💤 ±0  0 ❌ ±0 

Results for commit f6e2fa0. ± Comparison against base commit f241251.

@bentsku bentsku mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @coveralls