fix S3 List* pagination CommonPrefixes #9608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #9605, we were not handling properly the
Max*
argument when combined withDelimiter
andPrefix
, which returnsCommonPrefixes
.Here's the description of the
Delimiter
parameter, which helps understand the behavior:The behavior is most
List*
operations is pretty close, but has subtle changes between them.Changes
List*
, especially around pagination, as those are quite verbose and thetest_s3
file is becoming extremely huge (>10k lines) into its own file.ListParts
which doesn't have theCommonPrefix
behavior.ListObjects
ListObjectsV2
ListObjectVersions
ListMultipartUploads
EDIT: it was green before rebasing, pipeline is struggling (kclpy): https://app.circleci.com/pipelines/github/localstack/localstack/20034/workflows/a3805d65-c1b9-4708-a79b-f5ceed202830
Testing notes
I've also re-ran external test suites with this change and it's all green there as well.