Skip to content

update SQS QueryAPI to use new aws client factory #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

update SQS QueryAPI to use new aws client factory #8417

merged 1 commit into from
Jun 2, 2023

Conversation

thrau
Copy link
Member

@thrau thrau commented Jun 1, 2023 •
edited
Loading

Uses the new connect_to construct instead of aws_stack to connect to SQS in the SQS Query API. I'd like to use this later to try out #7396 /cc @viren-nadkarni @dfangl

I also removed a couple of tests that were covering deprecated behavior

  • test_call_fifo_queue_url
  • test_request_via_url

@thrau thrau requested a review from baermat as a code owner June 1, 2023 16:01
@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label Jun 1, 2023
baermat
baermat approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
should we specifically state the test-names in the PR description for traceability? No idea if we will ever need that though.

@coveralls
Copy link

Coverage Status

coverage: 82.702% (-0.006%) from 82.708% when pulling 961a224 on sqs-update-query-api into b99e2af on master.

@thrau thrau merged commit 284b5e2 into master Jun 2, 2023
@thrau thrau deleted the sqs-update-query-api branch June 2, 2023 16:48
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baermat baermat baermat approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@thrau @coveralls @baermat @dfangl