Use non-default formatted access key ID for tests #8204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
3 times, most recently
from
083f912 to
0bf5d93
Compare
viren-nadkarni
added
the
semver: minor
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
0bf5d93 to
c4449e5
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
3 times, most recently
from
a554e1b to
62a829f
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
62a829f to
ef98a30
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
ef98a30 to
832502e
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
2 times, most recently
from
3b74fa2 to
9b1350a
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
6 times, most recently
from
5f43208 to
d6fa923
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
d6fa923 to
148d4fd
Compare
viren-nadkarni
changed the title
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
3 times, most recently
from
819a00e to
a3786df
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
a3786df to
0abd949
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
11 times, most recently
from
eb815a5 to
7fccaa6
Compare
viren-nadkarni
commented
Feb 5, 2024
localstack/services/infra.py
Outdated
| os.environ["AWS_SECRET_ACCESS_KEY"] = constants.INTERNAL_AWS_SECRET_ACCESS_KEY | ||
| session = boto3.Session() | ||
| credentials = session.get_credentials() | ||
| assert credentials |
There was a problem hiding this comment.
Boto credentials must be explicit and determined from the request context
viren-nadkarni
commented
Feb 5, 2024
localstack/constants.py
Outdated
| @@ -8,9 +8,6 @@ | |||
| # constant to represent the "local" region, i.e., local machine | |||
| REGION_LOCAL = "local" | |||
|
|
|||
| # dev environment | |||
| ENV_DEV = "dev" | |||
|
|
|||
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
7fccaa6 to
41ae35b
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
3 times, most recently
from
79b6693 to
85f36ec
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
2 times, most recently
from
d293f5e to
78f7520
Compare
This was referenced Feb 13, 2024
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
3 times, most recently
from
1b8a96a to
ea9cbb0
Compare
viren-nadkarni
force-pushed
the
formatted-access-key-id-for-tests
branch
from
ea9cbb0 to
d2af625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes use of formatted access key IDs for tests that resolve to
000000000001(for primary account) and000000000002(for secondary account). The primary account is used for all tests (via theaws_clientfixture) whereas the latter is used for cross-account testing (viasecondary_aws_client). This PR also changes to a non-default test region to make sure multi-region works correctly.In effect, this assures that all services in LocalStack now can work with any arbitrary account ID, and furthermore that service integrations also use the correct account ID. Prior to this PR the fallback account ID
000000000000and default regionus-east-1was used across LocalStack. For example, when using a service integration with a non-fallback account ID, the called service would still use the fallback account ID.Related
Supersedes: #7040
Closes: #7041