-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
add in-memory ASF request dispatching for boto clients #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e48f6e5
to
7038265
Compare
7038265
to
ead511a
Compare
8f10977
to
67edc7f
Compare
67edc7f
to
0a1d555
Compare
9d4ae7e
to
93574e3
Compare
93574e3
to
69e4e34
Compare
4 tasks
using ben's PR instead #9569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to make calls from boto clients directly to a Gateway without an HTTP server roundtrip. This can make internal calls much faster because they don't require IO.
The mechanism used to achieve this is botocore's
before-send
event, which can be used to short-circuit the request logic by returning a response from the event handler, before the HTTP request is even made.I did some basic refactoring to make this easier, including:
localstack.runtime.components
as a place for runtime-level singleton componentsGateway
with the signaturedef handle(self, context: RequestContext, response: Response)
, which now makes the Gateway a drop-in replacement for a handler chain (and easier to call if you want to invoke it with a pre-existing RequestContext).TODO:
connect_to