Skip to content

Update python to 3.8.13 #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update python to 3.8.13 #5856

merged 1 commit into from
Apr 13, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Apr 13, 2022

PR reason

Currently, using curl with cipher AEAD-CHACHA20-POLY1305-SHA256 (only available in LibreSSL versions on Mac at this time) to connect to an endpoint on LocalStack, like this:

curl --ciphers AEAD-CHACHA20-POLY1305-SHA256 https://localhost.localstack.cloud:4566/health

will cause LocalStack to segfault and restart.
This seems to be fixed in the latest python docker image.

Fix

Update to python 3.8.13. You can see, in the changelogs (https://www.python.org/downloads/release/python-3813/) that openssl is updated (only mention for installers, but it seems to be the case in the docker images as well).
Output of openssl version in the 3.8.13 container:

OpenSSL 1.1.1n  15 Mar 2022

vs 3.8.12:

OpenSSL 1.1.1n  15 Mar 2022 (Library: OpenSSL 1.1.1d  10 Sep 2019)

This update (while done for security reasons) seems to also have fixed the segfault when using the cipher.

Unlike #5632 , this should not have any ill effects regarding the circleCI pipeline, so should be a quick fix for #5749 .

@dfangl dfangl requested a review from alexrashed as a code owner April 13, 2022 13:30
@dfangl dfangl temporarily deployed to localstack-ext-tests April 13, 2022 13:30 Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   57m 49s ⏱️ + 1m 39s
   958 tests ±0     918 ✔️ ±0  40 💤 ±0  0 ±0 
1 174 runs  ±0  1 106 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit fb697c3. ± Comparison against base commit 2d62321.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🚀

@dfangl dfangl merged commit ccf8c3b into master Apr 13, 2022
@dfangl dfangl deleted the python-3-8-13 branch April 13, 2022 14:37
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.807% when pulling fb697c3 on python-3-8-13 into 2d62321 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants