Skip to content

mm: support python3.9 #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matt-mercer
Copy link
Contributor

Please refer to the contribution guidelines in the README when submitting PRs.

@dfangl
Copy link
Member

dfangl commented Mar 9, 2022

Hi Matt! Thanks for your PR. However, this is potentially superseded by #5632.
You also did some work in the Dockerfile as I see, could you elaborate why you deem them necessary?

@matt-mercer
Copy link
Contributor Author

matt-mercer commented Mar 9, 2022

@dfangl

Hi Matt! Thanks for your PR. However, this is potentially superseded by #5632. You also did some work in the Dockerfile as I see, could you elaborate why you deem them necessary?

Ah hi .. great that python 3.10 is in flight .. I'll close and wait on that, feel I would be fighting circleci for some time yet with this,
In terms of the non python3.9 dockerfile changes, tbh, I'm just in the habit of compacting RUN commands to reduce the layers / image size otherwise hadolint tells me off ;)

@matt-mercer matt-mercer closed this Mar 9, 2022
@dfangl
Copy link
Member

dfangl commented May 3, 2022

Hi there @matt-mercer ! Just wanted to let you know python 3.10 support is now merged!

@matt-mercer matt-mercer deleted the mm-python-3-9 branch June 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants