Skip to content

Upgrade python version to 3.10 #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 3, 2022
Merged

Upgrade python version to 3.10 #5632

merged 19 commits into from
May 3, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Mar 8, 2022

Update LocalStack images & runtime to python 3.10

This PR makes couple of significant changes to the build pipeline in order to fully support python3.10 features over the build pipeline:

  • Usage of machine executors throughout the pipeline: In contrast to the current state, we now use machine executors for all steps of the pipeline, instead of just the steps needing docker. This is necessary due to the passing of the virtual environment from the install steps to later steps, and the difference in pathing between machine (using pyenv) and docker (installing in /usr/bin) images. Alternative would have been rebuilding the venv every time or trying to fix the venv paths for every job, which just begs for errors to occur.
  • Update of machine images: In order to use python 3.10.3 throughout the pipeline (and 3.10.4 in the docker image), I updated the machine images to ubuntu-2004:2022.04.1, which is available for both arm64 and amd64 machine executors (https://discuss.circleci.com/t/ubuntu-linux-vm-machine-images-2022-april-q2-update/43749).
  • In order to make future updating of machine images simpler, they are now defined as pipeline parameter on top of the config.yml file (split between amd64 and arm64, if different image versions should be necessary at some point, as was in the past), as well as the amd64 machine executor.
  • Updating docker is not necessary anymore, due to the updated images.
  • Adds python 3.10 as classifier in setup.cfg.

Other changes:

@dfangl dfangl temporarily deployed to localstack-ext-tests March 8, 2022 09:58 Inactive
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 9m 30s ⏱️ -25s
   982 tests ±0     942 ✔️ ±0  40 💤 ±0  0 ±0 
1 206 runs  ±0  1 138 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit 169269c. ± Comparison against base commit ff05478.

♻️ This comment has been updated with latest results.

@dfangl dfangl temporarily deployed to localstack-ext-tests March 8, 2022 11:27 Inactive
@coveralls
Copy link

coveralls commented Mar 8, 2022

Coverage Status

Coverage decreased (-0.04%) to 92.195% when pulling 6452e46 on python-3-10-upgrade into 2ef6c4e on master.

@dfangl dfangl temporarily deployed to localstack-ext-tests March 9, 2022 10:36 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests March 9, 2022 12:15 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests March 9, 2022 12:49 Inactive
@dfangl dfangl mentioned this pull request Mar 9, 2022
@dfangl dfangl force-pushed the python-3-10-upgrade branch from 40d11ac to db4a2c1 Compare March 11, 2022 15:10
@dfangl dfangl temporarily deployed to localstack-ext-tests March 11, 2022 15:10 Inactive
@dfangl dfangl force-pushed the python-3-10-upgrade branch from db4a2c1 to 164b1ad Compare March 14, 2022 10:03
@dfangl dfangl temporarily deployed to localstack-ext-tests March 14, 2022 10:03 Inactive
@dfangl dfangl force-pushed the python-3-10-upgrade branch from 164b1ad to 8c7ef71 Compare April 12, 2022 17:45
@dfangl dfangl temporarily deployed to localstack-ext-tests April 12, 2022 17:45 Inactive
@dfangl dfangl force-pushed the python-3-10-upgrade branch from 8c7ef71 to 77d3e23 Compare April 12, 2022 17:46
@dfangl dfangl temporarily deployed to localstack-ext-tests April 12, 2022 17:46 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests April 13, 2022 09:54 Inactive
@dfangl dfangl mentioned this pull request Apr 13, 2022
@dfangl dfangl force-pushed the python-3-10-upgrade branch from c8471e3 to 6452e46 Compare May 2, 2022 09:19
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 09:19 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 16:15 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 16:28 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 16:38 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 16:49 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 16:50 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 17:24 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 19:44 Inactive
@dfangl dfangl force-pushed the python-3-10-upgrade branch from 555b7f6 to 31933ac Compare May 2, 2022 20:29
@dfangl dfangl temporarily deployed to localstack-ext-tests May 2, 2022 20:29 Inactive
@dfangl dfangl marked this pull request as ready for review May 2, 2022 20:29
@dfangl dfangl requested review from thrau and alexrashed as code owners May 2, 2022 20:29
@dfangl
Copy link
Member Author

dfangl commented May 2, 2022

Marked as ready as last run was green. Current run is just evaluating the master rebase again.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic changes @dfangl! congrats for getting this one over the line! 💯

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of changes! Also nice to see that the pipeline is finally being cleaned up for the ARM tests! 🚀

@dfangl dfangl temporarily deployed to localstack-ext-tests May 3, 2022 08:17 Inactive
@dfangl dfangl merged commit 916f9ff into master May 3, 2022
@dfangl dfangl deleted the python-3-10-upgrade branch May 3, 2022 09:38
@alexrashed alexrashed mentioned this pull request Feb 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants