CFn: correctly set physical resource id for VpnGatewayAttachment #12870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 44m 27s ⏱️ + 1m 3s Results for commit 2cccd71. ± Comparison against base commit 3a47a8f. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 24m 4s ⏱️ Results for commit 2cccd71. ♻️ This comment has been updated with latest results. |
simonrw
requested review from
viren-nadkarni,
macnev2013,
dominikschubert and
pinzon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't currently set the physical resource id when creating a VPC gateway attachment. This means the new CFn provider fails to deploy the resource.
Changes