validate and add S3Control tests #10932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
the
semver: patch
bentsku
force-pushed
the
validate-s3-control
branch
from
0eba42b to
adb48c8
Compare
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 44m 25s ⏱️ + 3m 46s Results for commit 9bb20e8. ± Comparison against base commit c5fdfbe. This pull request removes 2 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cloutierMat
approved these changes
May 31, 2024
Comment on lines
104
to
107
| assert put_response["ResponseMetadata"]["HTTPStatusCode"] == 200 | ||
|
|
||
| get_response = s3control_client.get_public_access_block(AccountId=account_id) | ||
| assert access_block_config == get_response["PublicAccessBlockConfiguration"] |
There was a problem hiding this comment.
Question: Was there any issues with performing snapshots? Or reasoning as to why it is not needed?
There was a problem hiding this comment.
Oh no, this was a legacy test, I've just validated it but did not add snapshot. I think the goal would be to delete this one in favor of the newer ones created but currently skipped because the parity isn't there at all for now!
There was a problem hiding this comment.
I'll add a comment on the class to clarify still! thanks 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the S3 Control provider migration, I had started to add more tests with #9730.
Sadly, I didn't have the time to fully go through with the migration, and we didn't get a request yet for it. I'll focus more on it if we have then, it only needs a bit more work which should be fine (+ integration with S3 itself).
But as part of validating and removing
aws.unknowntest markers, I'm already cherry picking the tests.Changes