Fix/multi account kinesis #10188
Fix/multi account kinesis #10188
Conversation
macnev2013
added
aws:kinesis
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 21s ⏱️ Results for commit 306bfff. |
LocalStack Community integration with Pro 2 files 2 suites 1h 23m 7s ⏱️ Results for commit 1ca39aa. ♻️ This comment has been updated with latest results. |
macnev2013
force-pushed
the
fix/multi-account-kinesis
branch
from
306bfff to
011a732
Compare
| @@ -245,6 +245,7 @@ def _start_kcl_client_process( | |||
| env_vars = { | |||
| "AWS_CBOR_DISABLE": "true", | |||
| "AWS_ACCESS_KEY_ID": account_id, | |||
| "AWS_SECRET_ACCESS_KEY": account_id, | |||
There was a problem hiding this comment.
I think it is fine to set this here, but for this value it should be possible to set anything. Any particular reason to set it to the account id?
There was a problem hiding this comment.
For AWS_SECRET_ACCESS_KEY, we can set internal secret key (__internal_call__) or account_id here. @viren-nadkarni suggested to use account id here.
|
Ext Integration Tests workflow run: https://github.com/localstack/localstack-ext/actions/runs/7813257205 |
macnev2013
force-pushed
the
fix/multi-account-kinesis
branch
from
011a732 to
1ca39aa
Compare
Ext pipeline is 🟢 |
Motivation
This PR fixes multi-account support for kinesis related tests. This is a follow-up PR for #9785. We have discovered that some of the changes made in #8204 were causing failure in test cases when running against formatted-access-key-id-for-tests branch.
Changes
We have added
AWS_SECRET_ACCESS_KEYadditionally in the environment variable while running the KCL command. Since in the original PR we have removed the function setting up access key and secret key globally.Testing
Added non-default account related changes in commit f6c3fd.
TODO
What's left to do: