Skip to content

fix dynamodb router rule removal #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix dynamodb router rule removal #10172

merged 1 commit into from
Feb 5, 2024

Conversation

thrau
Copy link
Member

@thrau thrau commented Feb 4, 2024 •
edited
Loading

Motivation

shutdown hook of dynamodb was using an old API to remove rules from the router, leading to exceptions:

Traceback (most recent call last):
  File "/opt/code/localstack/localstack/utils/functions.py", line 41, in call_safe
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/code/localstack/localstack/services/dynamodb/provider.py", line 481, in on_before_stop
    ROUTER.remove_rule(rule)
    ^^^^^^^^^^^^^^^^^^
AttributeError: 'Router' object has no attribute 'remove_rule'

Changes

  • dynamodb routes are now removed using ROUTER.remove

@coveralls
Copy link

Coverage Status

coverage: 83.837% (+0.001%) from 83.836%
when pulling e970fd9 on fix-dynamobd-router
into f3811b7 on master.

@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label Feb 4, 2024
@viren-nadkarni viren-nadkarni mentioned this pull request Feb 5, 2024
Merged
@thrau thrau merged commit 220fd27 into master Feb 5, 2024
@thrau thrau deleted the fix-dynamobd-router branch February 5, 2024 10:10
@thrau
Copy link
Member Author

thrau commented Feb 5, 2024

thanks @viren-nadkarni ! totally missed your PR

maxhoheiser pushed a commit that referenced this pull request Feb 5, 2024
@thrau @maxhoheiser
fix dynamodb router rule removal (#10172)
75b10a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@giograno giograno Awaiting requested review from giograno

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thrau @coveralls @viren-nadkarni