Skip to content

[flang][CMake] CYGWIN: Fix undefined references at link time. #67105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[flang][CMake] CYGWIN: Fix undefined references at link time. #67105

wants to merge 1 commit into from
+2 −1

Conversation

carlo-bramini
Copy link
Contributor

While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time.
According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Sep 22, 2023
@mati865
Copy link
Contributor

mati865 commented May 13, 2025

That's the right thing to do but needs a rebase.

@carlo-bramini
[flang][CMake] CYGWIN: Fix undefined references at link time.
be4d868 
While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time. According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.
@carlo-bramini
Copy link
Contributor Author

Still unresolved in llvm-20.1.8.

@mati865
Copy link
Contributor

mati865 commented Jul 17, 2025

@jeremyd2019 could you review it?

jeremyd2019
jeremyd2019 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@jeremyd2019 jeremyd2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mati865
Copy link
Contributor

mati865 commented Jul 17, 2025

@carlo-bramini do you have write access? If not, you can ask the reviewer to merge it for you, but you should change to a proper email address first: https://llvm.org/docs/DeveloperPolicy.html#email-addresses
https://github.com/llvm/llvm-project/blob/b8264293a714347a77f150b109cfdde8665eeadc/.github/workflows/email-check.yaml#L35C41-L35C99

@carlo-bramini
Copy link
Contributor Author

Than you very much for your replies.

@carlo-bramini do you have write access?

No, I have not.

If not, you can ask the reviewer to merge it for you, but you should change to a proper email address first: https://llvm.org/docs/DeveloperPolicy.html#email-addresses https://github.com/llvm/llvm-project/blob/b8264293a714347a77f150b109cfdde8665eeadc/.github/workflows/email-check.yaml#L35C41-L35C99

The "Keep my email addresses private" option in my setting is already OFF.

@jeremyd2019
Copy link
Contributor

you might need to amend the commit with
git commit --amend --reset-author and force-push to get the authorship right then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyd2019 jeremyd2019 jeremyd2019 approved these changes

Assignees
No one assigned
Labels
flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlo-bramini @mati865 @jeremyd2019 @llvmbot