[mlir][linalg] Enable scalable vectorization of linalg.unpack (WIP) #149293
+114
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
vectorizeAsTensorUnpackOp
to support scalable vectorization by requiring user-specified vector sizes for both the read and write operations involved inlinalg.unpack
. Detailed rationale and an example are provided below.Conceptually,
linalg.unpack
consists of the following high-level steps:Currently, when vectorizing with user-provided vector sizes, only the sizes for the write operation (step 3) are required. Sizes for the read operation (step 1) are inferred from static shapes and inner tile sizes.
This logic breaks when the input shapes or tile sizes are dynamic (indeed,
vectorizeUnPackOpPrecondition
rejects such cases ATM and the vectorization fails). This patch addresses the issue by requiring explicit vector sizes for both the read and write sides, enabling scalable vectorization in such cases.Example:
Finally, this patch also extends
createReadOrMaskedRead
andcreateWriteOrMaskedWrite
to take scalable flags.