[llvm] simplify and clean-up DemangleConfig.h #149163
Open
+8
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify
DEMANGLE_
macro definitions inllvm/Demangle/DemangleConfig.h
for clarity/maintainability.Overview
DEMANGLE_DUMP_METHOD
,DEMANGLE_FALLTHROUGH
, andDEMANGLE_UNREACHABLE
macros to theirLLVM_
counterparts defined inllvm/Support/Compiler.h
DEMANGLE_
-prefixed macros that were only used withinDemangleConfig.h
Background
Demangle
component library to depend onSupport
, so there is no need for it to maintain copies of macros defined inllvm/Support/Compiler.h
.llvm/Demangle/ItaniumDemangle.h
lives underlibcxxabi
, it cannot directly reference theLLVM_
-prefixed macros so we defineDEMANGLE_
-prefixed aliases.Validation
clang-cl
and MSVCcl
.clang
andgcc
.