[llvm][blake3] Prefix blake3_hash4_neon #149139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #147948 blake3_hash4_neon became a public symbol (no longer static). Like other APIs introduced, it was not prefixed, resulting in conflicts if libblake3 and LLVM are both linked statically into the same binary.
|
@llvm/pr-subscribers-llvm-support Author: Paul Kirth (ilovepi) ChangesIn #147948 blake3_hash4_neon became a public symbol (no longer static). Full diff: https://github.com/llvm/llvm-project/pull/149139.diff 1 Files Affected:
diff --git a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
index d24657465dd8f..efdd65b692fbf 100644
--- a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
+++ b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
@@ -41,5 +41,6 @@
#define blake3_hash_many_avx512 llvm_blake3_hash_many_avx512
#define _blake3_hash_many_avx512 _llvm_blake3_hash_many_avx512
#define blake3_hash_many_neon llvm_blake3_hash_many_neon
+#define blake3_hash4_neon llvm_blake3_hash4_neon
#endif /* LLVM_BLAKE3_PREFIX_H */
|
|
Thanks. I didn't notice that was fixed there. Our Integration CI where this shows up is a bit slower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #147948 blake3_hash4_neon became a public symbol (no longer static).
Like other APIs introduced, it was not prefixed, resulting in conflicts if
libblake3 and LLVM are both linked statically into the same binary.