New DynamicLoaderDumpWithModuleList for coredump debugging #149019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch adds a new
DynamicLoaderDumpWithModuleList
plugin which can be used for coredump debugging. It leverages NT_FILE note in coredump to get module list instead of relying on posix rdebug data structure which highly depends on having a matching main executable available. Once the module list is generated a ObjectFilePlaceholder is created for each module.This feature is only activated by both two conditions are true:
use-module-list-dyld
setting is true (false by default)NT_FILE
notesPer my testing, Meta's internal modern Linux kernel seems to always generate
NT_FILE
note so this should be very useful.With this patch, coredump can be changed from
to
Test Plan:
Followup PR for
target module replace
command which enables to replace the object file place holders#148735