[clang][Modules] Reporting Errors for Duplicating Link Declarations in modulemaps
#148959
+91
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A different approach we can take is to deduplicate link libraries per module silently, and avoid adding any error checks. I think that is probably fine since there are no correctness issues. But I think it is also beneficial to report to the user that their modulemap contains duplicating link declarations. @Bigcheese @jansvoboda11 what do you think? |
|
I think a hard error is a bit too much initially, maybe let's introduce a warning first and then tighten the screws later? |
…an error whe link declarations are used in submodules.
…ure as indicated by the test case clang/test/Modules/autolink.m
…s a feature as indicated by the test case clang/test/Modules/autolink.m" This reverts commit 3286622.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the modulemap parsing logic to report errors if the parsing logic sees duplicating link declarations in the same module. Specifically, duplicating link declarations means multiple link declarations with the same string-literal in the same module. No errors are reported if a same link declaration exist in a submodule and its enclosing module.
rdar://155880064