TableGen: Avoid emitting trailing whitespace in StringToOffsetTable #148840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-tablegen Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/148840.diff 1 Files Affected:
diff --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cpp
index 9fb41485db745..d6d2c2590389a 100644
--- a/llvm/lib/TableGen/StringToOffsetTable.cpp
+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp
@@ -38,7 +38,7 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS,
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Woverlength-strings"
#endif
-{} constexpr char {}{}Storage[] = )",
+{} constexpr char {}{}Storage[] =)",
ClassPrefix.empty() ? "static" : "", ClassPrefix, Name);
// MSVC silently miscompiles string literals longer than 64k in some
|
nikic
reviewed
Jul 15, 2025
| @@ -38,7 +38,7 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS, | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Woverlength-strings" | |||
| #endif | |||
| {} constexpr char {}{}Storage[] = )", | |||
| {} constexpr char {}{}Storage[] =)", | |||
There was a problem hiding this comment.
I think you'd want to add a whitespace before "{\n" a few lines below then?
There was a problem hiding this comment.
I don't think so, it looks right as is. Every entry ends up on its own line, though under-indented
There was a problem hiding this comment.
I'm referring to the >64k case, which now would print ={ instead of = { I think. But it doesn't particularly matter...
nikic
approved these changes
Jul 15, 2025
| @@ -38,7 +38,7 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS, | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Woverlength-strings" | |||
| #endif | |||
| {} constexpr char {}{}Storage[] = )", | |||
| {} constexpr char {}{}Storage[] =)", | |||
There was a problem hiding this comment.
I'm referring to the >64k case, which now would print ={ instead of = { I think. But it doesn't particularly matter...
arsenm
force-pushed
the
users/arsenm/tablegen/use-string-offset-table-runtime-libcall-names
branch
3 times, most recently
from
0798c63 to
b113ff2
Compare
Base automatically changed from
users/arsenm/tablegen/use-string-offset-table-runtime-libcall-names
to
main
July 15, 2025 14:24
arsenm
force-pushed
the
users/arsenm/tablegen/avoid-trailing-whitespace-string-to-offset-table
branch
from
8e3742e to
74ed3cc
Compare
arsenm
deleted the
users/arsenm/tablegen/avoid-trailing-whitespace-string-to-offset-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.