[Clang] Remove explicit object from non member function. #148807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Corentin Jabot (cor3ntin) ChangesTo avoid crashing later (as we assume only member functions can have explicit parameters) Fixes #113185 Full diff: https://github.com/llvm/llvm-project/pull/148807.diff 2 Files Affected:
diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp
index 661746731fdcc..bb114aff2366b 100644
--- a/clang/lib/Sema/SemaType.cpp
+++ b/clang/lib/Sema/SemaType.cpp
@@ -4860,7 +4860,9 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state,
S.Diag(First->getBeginLoc(),
diag::err_explicit_object_parameter_invalid)
<< First->getSourceRange();
-
+ // Do let non-member function have explicit parameters
+ // to not break assumptions elsewhere in the code.
+ First->setExplicitObjectParameterLoc(SourceLocation());
D.setInvalidType();
AreDeclaratorChunksValid = false;
}
diff --git a/clang/test/SemaCXX/cxx2b-deducing-this.cpp b/clang/test/SemaCXX/cxx2b-deducing-this.cpp
index 6987d0c020457..2253cbb26285e 100644
--- a/clang/test/SemaCXX/cxx2b-deducing-this.cpp
+++ b/clang/test/SemaCXX/cxx2b-deducing-this.cpp
@@ -1347,3 +1347,13 @@ int main() {
// expected-note@#S3-f-cand2 {{candidate function not viable: no known conversion from 'S3' to 'int' for object argument}}
}
}
+
+namespace GH113185 {
+
+void Bar(this int) { // expected-note {{candidate function}}
+ // expected-error@-1 {{an explicit object parameter cannot appear in a non-member function}}
+ Bar(0);
+ Bar(); // expected-error {{no matching function for call to 'Bar'}}
+}
+
+}
|
To avoid crashing later (as we assume only member functions can have explicit parameters) Fixes llvm#113185
cor3ntin
force-pushed
the
corentin/gh113185
branch
from
bf204f0 to
25d5589
Compare
zyn0217
approved these changes
Jul 15, 2025
shafik
reviewed
Jul 15, 2025
|
|
||
| // Do let non-member function have explicit parameters | ||
| // to not break assumptions elsewhere in the code. | ||
| First->setExplicitObjectParameterLoc(SourceLocation()); |
There was a problem hiding this comment.
I realize this is invalid and will get diagnosed as so but don't we have the source location?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid crashing later (as we assume only member functions can have explicit object parameters)
Fixes #113185