This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21615 ]] Fix emscripten release build error #7592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an emscripten build error that occurs when building the emscripten standalone in release mode. This is caused by the use of an JavaScript feature (template literals) that is unrecognised by older emscripten emsdk tools.
runrevmark
approved these changes
Jul 1, 2021
|
@livecode-vulcan review ok 045fbe4 |
|
💙 review by @runrevmark ok 045fbe4 |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 1, 2021
…mplate_literal [[ Bug 21615 ]] Fix emscripten release build error This patch fixes an emscripten build error that occurs when building the emscripten standalone in release mode. This is caused by the use of an JavaScript feature (template literals) that is unrecognised by older emscripten emsdk tools.
|
😎 test success 045fbe4
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an emscripten build error that occurs when building the
emscripten standalone in release mode. This is caused by the use of an
JavaScript feature (template literals) that is unrecognised by older
emscripten emsdk tools.