This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 13085 ]] Add field equivalents of some paragraph properties #7195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montegoulding
force-pushed
the
paragraphprops-b
branch
from
43781cf to
84558e4
Compare
This patch makes `leftIndent`, `rightIndent`, `spaceAbove` and `spaceBelow` which were previously only line chunk properties properties of fields similar to `firstIndent` etc. This allows them to be set for all paragraphs in a field at once rather than setting the properties on individual paragraphs.
montegoulding
force-pushed
the
paragraphprops-b
branch
from
84558e4 to
72fb3b1
Compare
|
Round trip to disk tests will merge up from this PR so we may want to merge that in and up before reviewing this. They pass locally though. |
|
@montegoulding and @runrevmark - When I saw this PR I thought of enhancement request #11934. Could an argument be made that the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
leftIndent,rightIndent,spaceAboveandspaceBelowwhich were previously only line chunk properties properties of fields similar
to
firstIndentetc. This allows them to be set for all paragraphs in afield at once rather than setting the properties on individual paragraphs.