[22103] Ensure effective textFont of chunk reports correct value #7192
Conversation
| @@ -2438,6 +2438,10 @@ void MCField::GetEffectiveTextFontOfCharChunk(MCExecContext& ctxt, uint32_t p_pa | |||
|
|
|||
| if (r_mixed) | |||
| return; | |||
|
|
|||
| if(!MCStringIsEmpty(*t_value)) | |||
There was a problem hiding this comment.
Why is the check for the non-empty string necessary?
There was a problem hiding this comment.
I think the effective textFont of a chunk cannot be empty. It *t_value is nil or kMCEmptyString then the effective textFont of a chunk should be the effective textFont of the field (i.e. GetEffectiveTextFont(ctxt, r_value); from above)
There was a problem hiding this comment.
Okay so - I don't think t_value can be nil :)
The problem here is an incorrect use of the GetCharPropCharChunk method I think... It is being called in 'effective'; mode - so the method should be:
MCAutoStringRef t_default;
GetEffectiveTextFont(ctxt, &t_default);
GetCharPropOfCharChunk< PodFieldPropType<MCStringRef> >(ctxt, this, p_part_id, si, ei, &MCBlock::GetTextFont, true, *t_default, r_mixed, r_value);
Here we are calling them method in question in 'effective' mode, which means it uses t_default as the value to use when a style run has the property unset. Of course, appropriate tests will determine whether this is correct :)
There was a problem hiding this comment.
I have tried this ^^^^ with the sample stack attached to the bug report and for the first line (where its textFont is not set - it is just the textfont of the field that is set) it returns empty for the effective textFont (and r_value is NULL in this case):
No description provided.