clang-tidy: use const ref for exeption_ptr

neheb · neheb · commit 972961d31cac · 2022-07-01T21:47:58.000-07:00
Found with performance-unnecessary-value-param

Signed-off-by: Rosen Penev &lt;rosenp@gmail.com&gt;
diff --git a/libxml++/exceptions/wrapped_exception.cc b/libxml++/exceptions/wrapped_exception.cc
@@ -22,7 +22,7 @@ namespace xmlpp
 
 #ifdef LIBXMLXX_HAVE_EXCEPTION_PTR
 
-wrapped_exception::wrapped_exception(std::exception_ptr exception_ptr)
+wrapped_exception::wrapped_exception(const std::exception_ptr& exception_ptr)
   : exception("Wrapped exception"), exception_ptr_(exception_ptr)
 {
 }
diff --git a/libxml++/exceptions/wrapped_exception.h b/libxml++/exceptions/wrapped_exception.h
@@ -39,7 +39,7 @@ class wrapped_exception : public exception
 {
 public:
   LIBXMLPP_API
-  explicit wrapped_exception(std::exception_ptr exception_ptr);
+  explicit wrapped_exception(const std::exception_ptr& exception_ptr);
   LIBXMLPP_API ~wrapped_exception() noexcept override;
 
   LIBXMLPP_API void raise() const override;

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ namespace xmlpp`
`22`	`22`
`23`	`23`	`#ifdef LIBXMLXX_HAVE_EXCEPTION_PTR`
`24`	`24`
`25`		`-wrapped_exception::wrapped_exception(std::exception_ptr exception_ptr)`
	`25`	`+wrapped_exception::wrapped_exception(const std::exception_ptr& exception_ptr)`
`26`	`26`	`: exception("Wrapped exception"), exception_ptr_(exception_ptr)`
`27`	`27`	`{`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class wrapped_exception : public exception`
`39`	`39`	`{`
`40`	`40`	`public:`
`41`	`41`	`LIBXMLPP_API`
`42`		`- explicit wrapped_exception(std::exception_ptr exception_ptr);`
	`42`	`+ explicit wrapped_exception(const std::exception_ptr& exception_ptr);`
`43`	`43`	`LIBXMLPP_API ~wrapped_exception() noexcept override;`
`44`	`44`
`45`	`45`	`LIBXMLPP_API void raise() const override;`