Introduce git_object_id_from... APIs
#7001
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomson
force-pushed
the
ethomson/object_id
branch
6 times, most recently
from
3d64cee to
eae19b4
Compare
Introduce APIs within the `git_object` namespace to calculate the IDs of objects based on their raw content.
Using the `git_object_id_from` is an overall code simplification; switch to it.
Hash generation is not a concern of the object database; deprecate `git_odb_hash`.
ethomson
force-pushed
the
ethomson/object_id
branch
from
eae19b4 to
db23a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
git_object_id_from...APIs; these allow consumers to calculate object IDs from raw content either in a buffer, or on-disk. This deprecatesgit_odb_hashandgit_odb_hashfile.These are basically just refactorings of those old APIs into a new namespace that takes an options structure for SHA256 compatibility. In addition,
object_typeis moved into the options structure since most consumers likely only ever hash blobs and are not playing with other types. Finally, filters are now optional, to remove the internalhashfd_filteredAPIs and to better supportgit_repository_hashfile.