-
Notifications
You must be signed in to change notification settings - Fork 474
Laravel 9 support #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 9 support #546
Conversation
Updated Travis CI config but as pointed out in #519, it would be great to move forward with GitHub Actions. |
Worth adding PHP 8.1 also? |
Yes. No point in adding it to the Travis config which doesn't run anymore, but if #519 moves forward, 8.1 should definitely be added to the tests matrix. |
GitHub Actions have been added into the v5 branch, but not v6? I guess this PR should bring them in and update them to include PHP 8.1. Hopefully then we can get it merged and a new release tagged for L9? |
Laravel 9.0.0 is now released. Any update on this PR? |
Any news on this? |
I'm also watching this. |
Watching... |
Updated the PR with the changes merged in v5 to move to GitHub Actions. @lazychaser any chance this can move this forward soon? Thank you! |
@lazychaser I added PHP 8.1 to the tests matrix and fixed support for PHPUnit typing updates. I did a test run on our fork as this PR needs approval for its workflow to run, and unfortunately, tests are failing except on PHP 7.2, which is quite strange knowing that the tests are running on your v5 branch. Can you help? |
@ifox Just see warnings in 7.2 tests (PHPUnit 8.5.23), for example:
Other tests uses PHPUnit 9.5.13, where these annotations was removed and so failed. |
Any fork version for temporary solution? |
@eudj1n thanks for looking into it, I fixed it and the tests are running now: https://github.com/area17/laravel-nestedset/actions/runs/1823745005. To be clear, I'm not the maintainer of this package, I'm only trying to help this project to be able to release Laravel 9 support on https://github.com/area17/twill. @sawirricardo I guess you can use our fork for now if you really need it. |
+1 |
Ah thanks @ifox . I also made one while commenting that though. May be someone will find this useful temporarily.
|
Thanks, guys. Merged and tagged. |
No description provided.