Skip to content

Laravel 9 support #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 11, 2022
Merged

Laravel 9 support #546

merged 10 commits into from
Feb 11, 2022

Conversation

ifox
Copy link
Contributor

@ifox ifox commented Jan 25, 2022

No description provided.

@ifox
Copy link
Contributor Author

ifox commented Jan 25, 2022

Updated Travis CI config but as pointed out in #519, it would be great to move forward with GitHub Actions.

@lazychaser lazychaser marked this pull request as ready for review January 26, 2022 06:04
@glennjacobs
Copy link

Worth adding PHP 8.1 also?

@ifox
Copy link
Contributor Author

ifox commented Jan 26, 2022

Yes. No point in adding it to the Travis config which doesn't run anymore, but if #519 moves forward, 8.1 should definitely be added to the tests matrix.

@glennjacobs
Copy link

GitHub Actions have been added into the v5 branch, but not v6?

I guess this PR should bring them in and update them to include PHP 8.1.

Hopefully then we can get it merged and a new release tagged for L9?

@glennjacobs
Copy link

Laravel 9.0.0 is now released. Any update on this PR?

@sawirricardo
Copy link

Any news on this?

@crlcu
Copy link

crlcu commented Feb 9, 2022

I'm also watching this.

@razisayyed
Copy link

Watching...

@ifox
Copy link
Contributor Author

ifox commented Feb 9, 2022

Updated the PR with the changes merged in v5 to move to GitHub Actions.

@lazychaser any chance this can move this forward soon? Thank you!

@ifox ifox deleted the branch lazychaser:v6 February 9, 2022 11:55
@ifox ifox closed this Feb 9, 2022
@ifox ifox deleted the v6 branch February 9, 2022 11:55
@ifox ifox restored the v6 branch February 9, 2022 11:56
@ifox ifox reopened this Feb 9, 2022
@pauldwight pauldwight mentioned this pull request Feb 9, 2022
@ifox
Copy link
Contributor Author

ifox commented Feb 9, 2022

@lazychaser I added PHP 8.1 to the tests matrix and fixed support for PHPUnit typing updates. I did a test run on our fork as this PR needs approval for its workflow to run, and unfortunately, tests are failing except on PHP 7.2, which is quite strange knowing that the tests are running on your v5 branch. Can you help?

@eudj1n
Copy link

eudj1n commented Feb 10, 2022

@lazychaser I added PHP 8.1 to the tests matrix and fixed support for PHPUnit typing updates. I did a test run on our fork as this PR needs approval for its workflow to run, and unfortunately, tests are failing except on PHP 7.2, which is quite strange knowing that the tests are running on your v5 branch. Can you help?

@ifox Just see warnings in 7.2 tests (PHPUnit 8.5.23), for example:

The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9.Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageMatches() instead

Other tests uses PHPUnit 9.5.13, where these annotations was removed and so failed.

@sawirricardo
Copy link

Any fork version for temporary solution?

@christoph-kluge
Copy link

christoph-kluge commented Feb 10, 2022

Added and fixed deprecations here: #550

Works fine on php 8.1. In case someone needs this immediately.

What a coincidence. @ifox pushed a commit almost at the same time.

@ifox
Copy link
Contributor Author

ifox commented Feb 10, 2022

@eudj1n thanks for looking into it, I fixed it and the tests are running now: https://github.com/area17/laravel-nestedset/actions/runs/1823745005.

To be clear, I'm not the maintainer of this package, I'm only trying to help this project to be able to release Laravel 9 support on https://github.com/area17/twill.

@sawirricardo I guess you can use our fork for now if you really need it.

@phh
Copy link

phh commented Feb 10, 2022

+1

@sawirricardo
Copy link

@eudj1n thanks for looking into it, I fixed it and the tests are running now: https://github.com/area17/laravel-nestedset/actions/runs/1823745005.

To be clear, I'm not the maintainer of this package, I'm only trying to help this project to be able to release Laravel 9 support on https://github.com/area17/twill.

@sawirricardo I guess you can use our fork for now if you really need it.

Ah thanks @ifox . I also made one while commenting that though. May be someone will find this useful temporarily.

"repositories":[
       {
             "type":"github",
             "url":"https://github.com/sawirricardo/laravel-nestedset"
     }
],
"required":{
      "kalnoy/nested-set":"^6.0"
}

@lazychaser lazychaser merged commit bcfbcce into lazychaser:v6 Feb 11, 2022
@lazychaser
Copy link
Owner

Thanks, guys. Merged and tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants