replace save with savefig including kwargs support

subratappt · subratappt · commit 6586ec67bf07 · 2022-01-30T20:14:05.000+05:30
diff --git a/matplotlibcpp.h b/matplotlibcpp.h
@@ -1,7 +1,7 @@
 #pragma once
 /*****************************************************************
- Python headers must be included before any system headers, since 
-                   they define _POSIX_C_SOURCE                    
+ Python headers must be included before any system headers, since
+                   they define _POSIX_C_SOURCE
 ******************************************************************/
 #include <Python.h>
 
@@ -2685,28 +2685,31 @@ inline void pause(Numeric interval) {
     Py_DECREF(res);
 }
 
-inline void save(const std::string& filename, const int dpi = 0) {
-    detail::_interpreter::get();
-
+inline void savefig(const std::string& filename,
+                    const std::map<std::string, std::string>& keywords = {}) {
     PyObject* pyfilename = PyString_FromString(filename.c_str());
 
     PyObject* args = PyTuple_New(1);
     PyTuple_SetItem(args, 0, pyfilename);
 
     PyObject* kwargs = PyDict_New();
-
-    if (dpi > 0) {
-        PyDict_SetItemString(kwargs, "dpi", PyLong_FromLong(dpi));
+    for (auto it = keywords.begin(); it != keywords.end(); ++it) {
+        PyDict_SetItemString(kwargs, it->first.c_str(), PyUnicode_FromString(it->second.c_str()));
     }
 
     PyObject* res = PyObject_Call(detail::_interpreter::get().s_python_function_save, args, kwargs);
-    if (!res) throw std::runtime_error("Call to save() failed.");
+    if (!res) throw std::runtime_error("Call to savefig() failed.");
 
-    Py_DECREF(args);
     Py_DECREF(kwargs);
+    Py_DECREF(args);
     Py_DECREF(res);
 }
 
+inline void save(const std::string& filename) {
+    std::cerr << "matplotlibcpp::save is deprecated, use savefig instead\n";
+    matplotlibcpp::savefig(filename);
+}
+
 inline void rcparams(const std::map<std::string, std::string>& keywords = {}) {
     detail::_interpreter::get();
     PyObject* args   = PyTuple_New(0);
