-
Notifications
You must be signed in to change notification settings - Fork 135
TODO : HDW Implementation #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Yes, this is the idea. I will need some time to think of proper way of proceeding with this before reviewing this PR. Bear with me. |
Sure. Till then I will read more about BIP 32. |
I had a look at it and just realised that you are just wrapping around the python-mnemonic library. The existing code wraps another library. The goal was to implement them from scratch in an easy to understand way (clean code, comments), etc. for educational purposes. |
Sure , I will try to implement it from scratch with comments. |
I have tried to implement class HDW from scratch. I was thinking to proceed forward with |
Hi @karask I have implemented
Class I have also checked example file hdkeys.py to make sure the code runs appropriately. If there are any modifications you want me to make, please let me know. |
Hi @karask |
Hi @guptamukund22 ! My apologies for taking so long to look into this. I did not have time after your reminder and have seen it again now that I have some time. Code looks OK. Some tests and an example would help a lot on this. I intend to keep the old code (that wraps another library) as well until we ensure that everything works as expected with this one (creating keys is pretty critical !). Again thanks for the contribution! |
In TODO , it is mentioned to create a simple version of HDW as wrapped in hdwallet.py. This code is just my implementation after reading BIP 39 Documentation . I wanted to clarify whether this is what is expected before I move further with BIP 32.