Skip to content

Commit 38d87a8

Browse files
committed
Fix tests.
1 parent 71d55f1 commit 38d87a8

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

src/judge0/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def resolve_client(
2626
submissions = [submissions]
2727

2828
# Check which client supports all languages from the provided submissions.
29-
languages = (submission.language_id for submission in submissions)
29+
languages = [submission.language_id for submission in submissions]
3030

3131
for flavor in Flavor:
3232
client = _get_implicit_client(flavor)

tests/test_api.py

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1+
import judge0
12
import pytest
23

3-
from judge0 import (
4-
Flavor,
5-
JUDGE0_IMPLICIT_CE_CLIENT,
6-
JUDGE0_IMPLICIT_EXTRA_CE_CLIENT,
7-
Language,
8-
Submission,
9-
)
4+
from judge0 import Flavor, Language, Submission
105
from judge0.api import resolve_client
116

127
DEFAULT_CLIENTS = (
@@ -30,19 +25,20 @@ def test_resolve_client_with_explicit_client(client, request):
3025
[
3126
[
3227
Flavor.CE,
33-
JUDGE0_IMPLICIT_CE_CLIENT,
28+
"JUDGE0_IMPLICIT_CE_CLIENT",
3429
],
3530
[
3631
Flavor.EXTRA_CE,
37-
JUDGE0_IMPLICIT_EXTRA_CE_CLIENT,
32+
"JUDGE0_IMPLICIT_EXTRA_CE_CLIENT",
3833
],
3934
],
4035
)
4136
def test_resolve_client_with_flavor(
4237
flavor,
4338
expected_client,
4439
):
45-
assert resolve_client(client=flavor) is expected_client
40+
# We have to use getattr since both implicit clients are initially None.
41+
assert resolve_client(client=flavor) is getattr(judge0, expected_client)
4642

4743

4844
@pytest.mark.parametrize(
@@ -88,7 +84,7 @@ def test_resolve_client_common_ce_client():
8884

8985
submissions = [cpp_submission, py_submission]
9086

91-
assert resolve_client(submissions=submissions) is JUDGE0_IMPLICIT_CE_CLIENT
87+
assert resolve_client(submissions=submissions) is judge0.JUDGE0_IMPLICIT_CE_CLIENT
9288

9389

9490
def test_resolve_client_common_extra_ce_client():
@@ -104,4 +100,7 @@ def test_resolve_client_common_extra_ce_client():
104100

105101
submissions = [cpp_submission, py_submission]
106102

107-
assert resolve_client(submissions=submissions) is JUDGE0_IMPLICIT_EXTRA_CE_CLIENT
103+
assert (
104+
resolve_client(submissions=submissions)
105+
is judge0.JUDGE0_IMPLICIT_EXTRA_CE_CLIENT
106+
)

0 commit comments

Comments
 (0)